Skip to content

pipes.rs: alias std::io::Result<Result<(), ()>>#12483

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:piperes
May 27, 2026
Merged

pipes.rs: alias std::io::Result<Result<(), ()>>#12483
sylvestre merged 1 commit into
uutils:mainfrom
oech3:piperes

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 26, 2026

Fixes cargo fmt breakage & concentrate usage of it.

@oech3 oech3 marked this pull request as ready for review May 26, 2026 15:41
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2026

GNU testsuite comparison:

GNU test failed: tests/cp/sparse-to-pipe. tests/cp/sparse-to-pipe is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cp/link-heap is now passing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented May 26, 2026

std::io::Result<Result<(), ()>> is a fairly unusual return type. Could we replace the nested Result with a dedicated enum to make the intent clearer?

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 27, 2026 via email

@sylvestre sylvestre merged commit a17c0be into uutils:main May 27, 2026
171 checks passed
@oech3 oech3 deleted the piperes branch May 27, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oech3 @xtqqczze @sylvestre